Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Cleanup #403

Merged
merged 4 commits into from
Aug 1, 2019
Merged

Cleanup #403

merged 4 commits into from
Aug 1, 2019

Conversation

AustinSchuh
Copy link
Contributor

Small cleanups to make k8s work with protobuf and work with restricted_to/compatible_with

@k8s-ci-robot
Copy link

Hi @AustinSchuh. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This matches gRPC and others' naming pattern for pyyaml.
This allows rules_k8s to work with other projects which load
com_github_yaml_pyyaml
@nlopezgi
Copy link
Contributor

/ok-to-test

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AustinSchuh, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nlopezgi nlopezgi merged commit 5648b17 into bazelbuild:master Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants