This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
Go resolver should return strings as is on any kind of error #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is how the python resolver behaves. Tested with bazel run //prow/cluster/monitoring:prometheus_operator on kubernetes/test-infra
smukherj1
requested review from
alex1545,
chrislovecnm,
erain and
nlopezgi
as code owners
fejta
approved these changes
Oct 18, 2019
|
@fejta: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
alex1545
approved these changes
Oct 18, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alex1545, fejta, smukherj1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Another fix for #433 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how the python resolver behaves. Tested with
bazel run //prow/cluster/monitoring:prometheus_operator on
kubernetes/test-infra