This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
Update docs. #67
Merged
Update docs. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
mattmoor
approved these changes
Nov 15, 2017
README.md
Outdated
| @@ -28,10 +28,10 @@ git_repository( | |||
|
|
|||
| load( | |||
| "@io_bazel_rules_docker//docker:docker.bzl", | |||
There was a problem hiding this comment.
We should load this from container:container.bzl if we're going to use this name (which we should!).
There was a problem hiding this comment.
Well spotted. Thanks and fixed.
Update the docs for the docker_rules.
According to https://docs.bazel.build/versions/master/command-line-reference.html#run run inherits from build and therefore we can omit the entry for run.
mattmoor
reviewed
Nov 16, 2017
| @@ -203,7 +203,6 @@ the following: | |||
| ```shell | |||
| $ cat .bazelrc | |||
| build --workspace_status_command=./print-workspace-status.sh | |||
| run --workspace_status_command=./print-workspace-status.sh | |||
There was a problem hiding this comment.
See commit message:
Simplify .bazelrc example. …
According to
https://docs.bazel.build/versions/master/command-line-reference.html#run
run inherits from build and therefore we can omit the entry for run.
|
Cool thanks. Travis only runs properly from PRs coming from branches on the main repo (b/c of secrets), and I'm just going to skip Bazel CI because this is README only. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the docs for the docker_rules.