Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Added toolchain support for Apple M1 and made toolchain_type public to allow extensions #697

Merged
merged 2 commits into from
May 16, 2022

Conversation

lomeshpatel
Copy link
Contributor

@lomeshpatel lomeshpatel commented May 13, 2022

  1. Added and registered kubectl_macos_arm64_toolchain
  2. Changed the name of kubectl_osx_toolchain to kubectl_macos_x86_64_toolchain and added an alias for backwards compatibility. Also updated the registration.
  3. Made toolchain/kubectl package public to allow for extensions for this toolchain_type

#696

lomeshpatel and others added 2 commits May 13, 2022 12:44
Added toolchain support for Apple M1 and made toolchain_type public to allow extensions
@k8s-ci-robot
Copy link

Hi @lomeshpatel. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lomeshpatel lomeshpatel changed the title #696 Added toolchain support for Apple M1 and made toolchain_type public to allow extensions Added toolchain support for Apple M1 and made toolchain_type public to allow extensions May 13, 2022
@fejta
Copy link
Contributor

fejta commented May 16, 2022

/ok-to-test

@k8s-ci-robot
Copy link

@lomeshpatel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-rules-k8s-e2e 833f4be link true /test pull-rules-k8s-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, lomeshpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta fejta merged commit 64268c4 into bazelbuild:master May 16, 2022
@lomeshpatel
Copy link
Contributor Author

@fejta I noticed that one of the checks failed, is that expected or do I need to fix something?

Also, can you please point me to the release process? I just would like to have some understanding of when these changes will be available.

@fejta fejta mentioned this pull request Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants