Separate loading repositories from things that might use those downloads #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `kotlin_repositories` macro is designed to download the third party dependencies that rules_kotlin has for itself. Because of the way that Bazel works, these must first be downloaded before they can be referred to by build files.
shs96c
requested review from
cgruber,
jin,
restingbull and
timpeut
as code owners
|
Are there any changes that you'd like to see to this PR? |
cgruber
requested changes
Jul 10, 2021
cgruber
added
component: common
P2
status: in review
|
Resolved by #564 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
kotlin_repositoriesmacro is designed to download the thirdparty dependencies that rules_kotlin has for itself. Because of the
way that Bazel works, these must first be downloaded before they can
be referred to by build files.