Ensure version of Android SDK is consistent when compiling kotlin targets #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviernotteghem
requested review from
cgruber,
jin,
timpeut and
restingbull
as code owners
restingbull
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible Kotlin targets within a project can depend on other libraries that depend themselves (as provided deps) on different version on Android SDK library. It's certainly not a good practice, but can happen.
In this case, because project android SDK appears later in the list of classpathes used for compilation when compiling kotlin targets, this different version of the Android SDK can take precedence and cause target failed to compile. An example is with android.os.BuildConfig.VERSION_CODE that might not contain latest entries in case different version of the SDK is older.