cleanup: don't pull pre-release java templates #806
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java template is exposed by bazel it self, and should point to whatever the current release of bazel has, instead of pulling a pre-5.x version.
manuelnaranjo
requested review from
cgruber,
timpeut and
restingbull
as code owners
|
Silly question -- is that template exposed on all versions of Bazel? |
Versions lower than 5.X don't support it, it was added for rules_kotlin almost a year ago bazelbuild/bazel#13790 bazelbuild/bazel#12994 So this change would break compatibility of rules_kotlin with pre 5 bazel, if that's a requirement I could try to make something that's portable, but how long are you going to keep that compatibility |
|
The template is pretty stable, as it's mostly just small improvement to the bash sniffing -- which is why I haven't been too worried. |
|
Alright, let's drop this then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java template is exposed by bazel it self, and should point to whatever
the current release of bazel has, instead of pulling a pre-5.x version.