Forward kwargs to _license #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to e.g. set visibility on license targets.
|
Sorry I missed this before. So, in general I think kwargs should pass through, but your PR comment intrigued me. Perhaps we only need to pass through visibility? Or maybe just force visibility=public. |
|
I didn't give this much thought, I just noticed that there wasn't any way to set a visibility other than private. Forcing visibility to be public sounds right to me based on your argument. |
|
Sorry I missed this |
Forcing license declarations to be public visible. I have yet to see a scenario where it should be private.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to e.g. set visibility on license targets.