Fix some bazel:lint warnings and use vanilla nodejs docker image to r…

…un it
bazelbuild · Dec 5, 2018 · 01ab48e · 01ab48e
1 parent 9df88bc
commit 01ab48e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -56,13 +56,18 @@ jobs:
   # Cannot be run on BuildKite (BazelCI), see
   # https://github.com/bazelbuild/continuous-integration/issues/338
   lint:
-    <<: *job_defaults
+    docker:
+      - image: circleci/node:10.12
     steps:
       - checkout:
           <<: *post_checkout
-      - *setup_bazelrc
+
+      - run: yarn install
 
       # Run the skylark linter to check our Bazel rules
+      # Note, this is not yet enforced, because
+      # - buildifier doesn't exit non-zero in the presence of lint warnings: https://github.com/bazelbuild/buildtools/issues/470
+      # - false positive for rule docstrings: https://github.com/bazelbuild/buildtools/issues/471
       - run: 'yarn bazel:lint ||
               (echo -e "\n.bzl files have lint errors. Please run ''yarn bazel:lint-fix''"; exit 1)'
 

diff --git a/internal/e2e/node_loader_no_preserve_symlinks/BUILD.bazel b/internal/e2e/node_loader_no_preserve_symlinks/BUILD.bazel
@@ -1,6 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test", "nodejs_binary")
+load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test")
 
 filegroup(
     name = "node_modules",

diff --git a/internal/e2e/node_loader_preserve_symlinks/BUILD.bazel b/internal/e2e/node_loader_preserve_symlinks/BUILD.bazel
@@ -1,6 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test", "nodejs_binary")
+load("@build_bazel_rules_nodejs//:defs.bzl", "jasmine_node_test")
 
 filegroup(
     name = "node_modules",