port #398 to new jasmine_node_test

add a test case for it
bazelbuild · Jun 4, 2019 · c3f9335 · c3f9335
1 parent 01a49a4
commit c3f9335
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/packages/jasmine/src/jasmine_node_test.bzl b/packages/jasmine/src/jasmine_node_test.bzl
@@ -59,7 +59,9 @@ def jasmine_node_test(
     all_data += [Label("@bazel_tools//tools/bash/runfiles")]
     entry_point = "@bazel/jasmine/src/jasmine_runner.js"
 
-    templated_args = ["$(location :%s_devmode_srcs.MF)" % name]
+    # If the target specified templated_args, pass it through.
+    templated_args = kwargs.pop("templated_args", []) + ["$(location :%s_devmode_srcs.MF)" % name]
+
     if coverage:
         templated_args = templated_args + ["--coverage"]
     else:

diff --git a/packages/jasmine/test/BUILD.bazel b/packages/jasmine/test/BUILD.bazel
@@ -71,3 +71,13 @@ jasmine_node_test(
         "@npm//v8-coverage",
     ],
 )
+
+jasmine_node_test(
+    name = "templated_args_test",
+    srcs = ["templated_args_test.js"],
+    jasmine = "@npm//jasmine",
+    deps = ["//:jasmine_runner"],
+    templated_args = [
+        "--node_options=--experimental-modules",
+    ],
+)
diff --git a/packages/jasmine/test/templated_args_test.js b/packages/jasmine/test/templated_args_test.js
@@ -0,0 +1,7 @@
+describe('args', () => {
+    it('should pass through templated_args', () => {
+        // without --node_options=--experimental-modules this will fail
+        import('../index');
+    });
+});
+