Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade rules_go version #2905

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Conversation

alexeagle
Copy link
Collaborator

Prereq for cross-compilation from M1 mac, it seems

@thesayyn
Copy link
Collaborator

thesayyn commented Sep 5, 2021

I also experience this issue with M1. rules_typescript (ts_devserver) rely on some of the removed internal apis ig.

@alexeagle
Copy link
Collaborator Author

yeah either we need intensive refactoring of how the devserver handles runfiles (IIRC there's no equivalent functionality still in that runfiles library) or just vendor the code we were originally using into our repo.

@alexeagle
Copy link
Collaborator Author

bazelbuild/rules_go#2076 (comment)

I'm not ready to figure out that refactoring right now so I'll just patch out this commit from our rules_go http_archive fetch. One day the merge conflict will bring someone back to this thread. Maybe me! :)

yup, here we are :/

@alexeagle alexeagle changed the title chore: upgrade rules_go, bazel versions chore: upgrade rules_go version Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants