Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(examples): use dev/prod entry points in angular app #3053

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

mgred
Copy link
Contributor

@mgred mgred commented Oct 31, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The entry point main.dev.ts in the angular example is not used for serving the app in "devmode".

What is the new behavior?

main.dev.ts is used to serve the app in "devmode".

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Some unused files are removed

this enables the `main.dev.ts` file to be used as entry
point served in devmode and also removes some unused files
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @jbedard any comments?

@alexeagle alexeagle merged commit 4127d29 into bazelbuild:stable Nov 4, 2021
alexeagle pushed a commit that referenced this pull request Dec 3, 2021
this enables the `main.dev.ts` file to be used as entry
point served in devmode and also removes some unused files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants