Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esbuild): add option to disable metafile generation #3066

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

mgred
Copy link
Contributor

@mgred mgred commented Nov 5, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Feature (please, look at the "Scope of the project" section in the README.md file)

What is the current behavior?

esbuild always generates *._metadata.json file.

What is the new behavior?

The new option metafile can turn of generation of the metafile.

This might be useful if one would like to inject the output into html as possible with @bazel/rollup.

Does this PR introduce a breaking change?

  • No

@google-cla google-cla bot added the cla: yes label Nov 5, 2021
@mgred mgred force-pushed the feat-eslint-optional-metafile branch from 3c2ccf6 to d2504f2 Compare November 5, 2021 18:23
@mgred mgred changed the title feat(esbuild): add option to disable metafile genration feat(esbuild): add option to disable metafile generation Nov 5, 2021
@mgred mgred force-pushed the feat-eslint-optional-metafile branch from d2504f2 to 107b4aa Compare November 5, 2021 20:58
@mgred mgred requested a review from soldair as a code owner November 5, 2021 20:58
Copy link
Collaborator

@mattem mattem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@mattem mattem merged commit 2960f54 into bazelbuild:stable Nov 11, 2021
@mgred mgred deleted the feat-eslint-optional-metafile branch June 23, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants