Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builtin): handle external repository file paths in js_library strip_prefix check #3076

Merged

Conversation

gregmagolan
Copy link
Collaborator

@gregmagolan gregmagolan commented Nov 11, 2021

Failure without the fix in js_library.bzl:

ERROR: /private/var/tmp/_bazel_gmagolan/e172f8159a8fef9694f6bd1b99308c59/external/npm/BUILD.bazel:57066:11: in _js_library rule @npm//:testy_copy_js_library: 
Traceback (most recent call last):
	File "/Users/gmagolan/oss/rules_nodejs/internal/js_library/js_library.bzl", line 243, column 30, in _impl
		path = _link_path(ctx, all_files),
	File "/Users/gmagolan/oss/rules_nodejs/internal/js_library/js_library.bzl", line 120, column 17, in _link_path
		fail("js_library %s strip_prefix path does not contain any of the provided sources" % ctx.label)
Error in fail: js_library @npm//:testy_copy_js_library strip_prefix path does not contain any of the provided sources
ERROR: Analysis of target '//internal/js_library/test/strip_prefix:external_test' failed; build aborted: Analysis of target '@npm//:testy_copy_js_library' failed

@gregmagolan gregmagolan merged commit c6ba226 into bazelbuild:stable Nov 11, 2021
@renovate renovate bot mentioned this pull request Mar 22, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants