Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump versioned browsers for rules_webtesting to 0.3.3 #3086

Merged

Conversation

CooperBills
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

No valid headless browsers or drivers are defined for M1 Mac hosts (Darwin arm64) in browsers-0.3.2.bzl, and tests fail.

Issue Number: #3085

What is the new behavior?

browsers-0.3.3.bzl defines browsers and drivers for M1 Mac hosts, and tests progress.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This does bump the versions of headless browsers being used, so there is possibility for regressions.

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there's also some dependency on having a new-enough rules_webtesting release installed, but since this is green that must mean we already had it.

Thanks!

@alexeagle alexeagle merged commit f5b1843 into bazelbuild:stable Nov 19, 2021
@CooperBills
Copy link
Contributor Author

Yep! rules_webtesting was bumped about 2 months ago which included these files, they just needed to be bumped: #2956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants