fix(esbuild): do not ignore annotations when the minify shorthand attribute is false
#3106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttribute is disabled Pure annotations are currently always ignored if `esbuild(minify = False)`. There are cases where a consumer will set fine-grained minification options through `args`, but currently cannot do this without setting `minify = True` as otherwise pure annotations would always be preserved. This magical behavior should be removed and the consumer should be responsible for enabling this if tree-shaking is undesirable.
devversion
requested review from
alexeagle,
gregmagolan and
mattem
as code owners
mattem
approved these changes
Dec 2, 2021
alexeagle
pushed a commit
that referenced
this pull request
Dec 3, 2021
…ttribute is disabled (#3106) Pure annotations are currently always ignored if `esbuild(minify = False)`. There are cases where a consumer will set fine-grained minification options through `args`, but currently cannot do this without setting `minify = True` as otherwise pure annotations would always be preserved. This magical behavior should be removed and the consumer should be responsible for enabling this if tree-shaking is undesirable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure annotations are currently always ignored if
esbuild(minify = False). There arecases where a consumer will set fine-grained minification options through
args, butcurrently cannot do this without setting
minify = Trueas otherwise pure annotationswould always be preserved.
This magical behavior should be removed and the consumer should be
responsible for enabling this if tree-shaking is undesirable.