Allow soft fail for "rbe_ubuntu1604" #3145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "rbe_ubuntu1604" is failing with Bazel@HEAD for a long time, mark it as soft fail to not block the downstream pipeline turning green. See #3121
meteorcloudy
requested review from
alexeagle,
gregmagolan,
mattem and
soldair
as code owners
alexeagle
approved these changes
Dec 16, 2021
alexeagle
pushed a commit
that referenced
this pull request
Dec 18, 2021
* Allow soft fail for "rbe_ubuntu1604" The "rbe_ubuntu1604" is failing with Bazel@HEAD for a long time, mark it as soft fail to not block the downstream pipeline turning green. See #3121 * Update presubmit.yml
|
This doesn't seem to be working. rules_nodejs is still failing on Ubuntu RBE (https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2291#c891e109-3d3f-4c4c-a032-b822a9217fb1) |
|
Yeah, but it's no longer blocking the downstream pipeline to be green: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2292 |
|
oh, I see -- sorry! it's just confusing the auto sheriff, that's all. We should maybe fix the autosheriff to ignore soft_fail stuff? |
|
Oh yeah, I also noticed that. Will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "rbe_ubuntu1604" is failing with Bazel@HEAD for a long time, mark it as soft fail to not block the downstream pipeline turning green.
See #3121
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information