fix(typescript): add build_test to ensure typecheck is run under --bu… #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
requested review from
gregmagolan,
mattem and
soldair
as code owners
alexeagle
force-pushed
the
tsc_typecheck_test
branch
from
a5c27a2
to
2687455
Compare
gregmagolan
reviewed
Jan 8, 2022
| This is considered a feature, as it allows you to have a faster development mode where type-checking | ||
| is not on the critical path. | ||
| - `[name]_typecheck` - this target will fail to build if the type-checking fails, useful for CI. | ||
| - `[name]_test` - a [`build_test`](https://github.com/bazelbuild/bazel-skylib/blob/main/rules/build_test.bzl) |
There was a problem hiding this comment.
maybe [name]_typecheck_test to be clear?
gregmagolan
reviewed
Jan 8, 2022
| is not needed to produce the default outputs. | ||
| This is considered a feature, as it allows you to have a faster development mode where type-checking | ||
| is not on the critical path. | ||
| - `[name]_typecheck` - this target will fail to build if the type-checking fails, useful for CI. |
There was a problem hiding this comment.
hmm. technically the build failure will be in the [name]_typings ts_project target and not the _typecheck target
There was a problem hiding this comment.
fixed the wording
gregmagolan
approved these changes
Jan 8, 2022
alexeagle
force-pushed
the
tsc_typecheck_test
branch
from
2687455
to
ad42f0c
Compare
alexeagle
added a commit
that referenced
this pull request
Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ild_tests_only