chore: cleanup windows build & test tags #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
commented
Jan 8, 2022
alexeagle
reviewed
Jan 8, 2022
| tags = [ | ||
| # no need to run on more than one platform | ||
| "no-bazelci-windows", | ||
| # diff_test has line endings issues on Windows |
There was a problem hiding this comment.
is it diff_test or stardoc? I'm still not clear where this bug actually originates
There was a problem hiding this comment.
hmm. let me double check
There was a problem hiding this comment.
checked locally. the only difference is the line endings so I'd call it a diff_test issue since we'd expect windows stardoc to output CRLF right?
gregmagolan
force-pushed
the
cleanup_windows_tags
branch
from
970a18e
to
7443731
Compare
alexeagle
approved these changes
Jan 8, 2022
gregmagolan
force-pushed
the
cleanup_windows_tags
branch
from
7443731
to
a251dc3
Compare
gregmagolan
force-pushed
the
cleanup_windows_tags
branch
from
a251dc3
to
baf3b7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.