fix: change all cfg=host and cfg=target executable attributes to cfg=exec #3215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
requested review from
alan-agius4,
alexeagle,
jbedard and
mattem
as code owners
gregmagolan
changed the title
gregmagolan
changed the title
gregmagolan
force-pushed
the
cfg_exec
branch
10 times, most recently
from
b56c710
to
dc751fd
Compare
alexeagle
approved these changes
Jan 11, 2022
| "../bazel-out/darwin-dbg/bin/src", | ||
| "../bazel-out/darwin-fastbuild/bin/src", | ||
| "../bazel-out/darwin_arm64-fastbuild/bin/src", | ||
| "../bazel-out/darwin-opt-exec-2B5CBBC6/bin/src", |
There was a problem hiding this comment.
do you know what the 2B5CBBC6 is based on? I hope it's a stable checksum that will match on another machine.
There was a problem hiding this comment.
John Cater says "the hex tag is just a hash of the execution platform" (bazelbuild/bazel#12403 (comment)) so it should be stable. Guessing it is a hash of "host" if the exec platform is the host since it is stable between k8, darwin & windows in these paths
|
|
||
| // Ensures that args are well formed. | ||
| // Work-around for an issue on Windows when exec bin path is not quoted. | ||
| // In --source-map, base=bazel-out/x64_windows-opt-exec-2B5CBBC6/bin must |
There was a problem hiding this comment.
interesting we didn't have this problem before, we had hyphens in the path already right?
There was a problem hiding this comment.
Yeah. I was puzzled. The extra -exec-2B5CBBC6 broke it when there were no quotes 🤷 Something fishy upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should have been "exec" all along.