refactor(concatjs): sync with internal change that exposes rootDirsRelative
#3517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elative` Tsickle now requires a `rootDirsRelative` public property on the TS host. This change has been implemented internally but hasn't been synced upstream, making it difficult to update to the latest `tsickle` externally.
devversion
requested review from
mattem,
gregmagolan and
alexeagle
as code owners
devversion
added a commit
to devversion/angular
that referenced
this pull request
Aug 2, 2022
Temporary patch until bazelbuild/rules_nodejs#3517 is available in another `rules_nodejs` release. We can remove this patch, but for now it doesn't hurt. On the external side the tsickle code path is not hit at all anyway, but we need to satisfy the TypeScript checker.
devversion
added a commit
to devversion/angular
that referenced
this pull request
Aug 2, 2022
Temporary patch until bazelbuild/rules_nodejs#3517 is available in another `rules_nodejs` release. We can remove this patch, but for now it doesn't hurt. On the external side the tsickle code path is not hit at all anyway, but we need to satisfy the TypeScript checker.
alexeagle
approved these changes
Aug 3, 2022
dylhunn
pushed a commit
to angular/angular
that referenced
this pull request
Aug 4, 2022
#47018) Temporary patch until bazelbuild/rules_nodejs#3517 is available in another `rules_nodejs` release. We can remove this patch, but for now it doesn't hurt. On the external side the tsickle code path is not hit at all anyway, but we need to satisfy the TypeScript checker. PR Close #47018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tsickle now requires a
rootDirsRelativepublic property on the TS host. This changehas been implemented internally but hasn't been synced upstream, making it difficult
to update to the latest
tsickleexternally.This is hopefully the last change in a while we need to sync up externally. It is still planned to
rework the whole rule to be owned by Angular directly, and not relying on the external
sync (might mean we need to diverge
ngc-wrappedinternally and externally)