Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for linux ppc64le and linux s390x #3574

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

npanpaliya
Copy link
Contributor

@npanpaliya npanpaliya commented Oct 10, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Tensorboard uses rules_nodejs during its build. And it fails on linux ppc64le or linux s390x with following error -

ERROR: /opt/conda/conda-bld/tensorboard_1665144934672/work/tensorboard/webapp/widgets/line_chart_v2/lib/worker/BUILD:89:13: While resolving toolchains for target //tensorboard/webapp/widgets/line_chart_v2/lib/worker:chart_worker: no matching toolchains found for types @build_bazel_rules_nodejs//toolchains/esbuild:toolchain_type
ERROR: Analysis of target '//tensorboard/pip_package:build_pip_package' failed; build aborted:
INFO: Elapsed time: 112.999s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (118 packages loaded, 1236 targets configured)
FAILED: Build did NOT complete successfully (118 packages loaded, 1236 targets configured)
Traceback (most recent call last):

Issue Number: N/A

What is the new behavior?

Tensorboard 2.10 compiled successfully with this change on linux ppc64le. I'm yet to verify the build on s390x.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@npanpaliya
Copy link
Contributor Author

Hello @alexeagle - Could you please help me understand read.fasterci/config.yaml check failure?

@npanpaliya npanpaliya marked this pull request as ready for review October 10, 2022 14:49
@alexeagle
Copy link
Collaborator

Can you also fix up https://github.com/bazelbuild/rules_nodejs/blob/stable/scripts/update-esbuild-versions.js#L7 ? that's the script which updates the toolchains/esbuild/esbuild_packages.bzl file.

I need to find a Googler to turn off that fasterci setup I think - you can ignore that.

Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alexeagle alexeagle merged commit e05786c into bazelbuild:stable Oct 10, 2022
@npanpaliya npanpaliya deleted the support-ppc64le-s390x branch October 11, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants