Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export TsConfigInfo in public interface #3578

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

sallustfire
Copy link
Contributor

@sallustfire sallustfire commented Oct 12, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe: Add API export

What is the current behavior?

The typescript package @npm//@bazel/typescript:index.bzl exports the public typescript rules interface including a rule called ts_config. However, ts_config returns a provider TsConfigInfo that is not publicly exported and is instead found under @rules_nodejs//nodejs/private:ts_config.bzl.

Issue Number: N/A

What is the new behavior?

TsConfigInfo is exported from @npm//@bazel/typescript:index.bzl alongside ts_config.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla
Copy link

google-cla bot commented Oct 12, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@alexeagle
Copy link
Collaborator

@sallustfire can you make the CLA bot happy? Google wants to have IP rights to all the code.

@sallustfire
Copy link
Contributor Author

Yep, looks like it is happy now. Let me know if you need anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants