perf: avoid calling to_list()

[manekinekko]

PR Checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature (please, look at the "Scope of the project" section in the README.md file)
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Closes #484

[alexeagle]

check the history / blame layer, I think these were added by Bazel team because implicit iteration on depsets is going away

[manekinekko]

Leaving this here as a reference:

According to the docs, both the to_list() and iterating over a depset are either not recommended or will be deprecated.

This thread recommends passing depsets to actions creation.

[manekinekko]

@alexeagle can you review this PR when you have time?