test(Karma): add e2e test for Karma files collected through sources_aspect #651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Karma should only load explicit node_sources and dev_scripts from
its deps and runtime_deps. There should not be a case where Karma
needs to load all files in a target.
For third-party deps, an explicit file from the package should be
provided to Karma instead of the entire package.
For example,
@npm//node_modules/rxjs:bundles/rxjs.umd.js
shouldbe used instead of
@npm//rxjs
.(This effectively means devserver and Karma do not know how to
serve node modules that are not in APF format, so users have to
explicitly specify the files instead of Karma blindly loading everything).
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information