[Zlib] update zlib version to zlib-1.2.12 #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
comius
approved these changes
Mar 31, 2022
|
Mirrored the zlib |
|
Do we want to do a new release of rules_proto with this included? As of right now, anything that uses an older rules_proto without overriding the zlib dependency will break. |
I created/tagged 4.0.0-39.19.2-2 release. |
|
Umm, is it supposed to be 4.0.0-3.19.2-2 instead? (there's an extra 9 :P) |
Thanks, fixed :) |
tetromino
pushed a commit
to bazelbuild/stardoc
that referenced
this pull request
Apr 4, 2022
To include bazelbuild/rules_proto#117, without which builds fail due to a missing zlib version.
BenHenning
added a commit
to oppia/oppia-proto-api
that referenced
this pull request
May 27, 2024
This ensures that an older zlib isn't referenced per bazelbuild/rules_proto#117.
BenHenning
added a commit
to oppia/oppia-android
that referenced
this pull request
May 27, 2024
This ensures the fixes explained in bazelbuild/rules_proto#117 and bazelbuild/bazel#16192 are included to fix CI breakages on this branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #117
According to zlib