-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Zlib] update zlib version to zlib-1.2.12 #117
Conversation
LGTM |
Mirrored the zlib |
Do we want to do a new release of rules_proto with this included? As of right now, anything that uses an older rules_proto without overriding the zlib dependency will break. |
I created/tagged 4.0.0-39.19.2-2 release. |
Umm, is it supposed to be 4.0.0-3.19.2-2 instead? (there's an extra 9 :P) |
Thanks, fixed :) |
To include bazelbuild/rules_proto#117, without which builds fail due to a missing zlib version.
This ensures that an older zlib isn't referenced per bazelbuild/rules_proto#117.
This ensures the fixes explained in bazelbuild/rules_proto#117 and bazelbuild/bazel#16192 are included to fix CI breakages on this branch.
Issue: #117
According to zlib