New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
non-root requirement seems too much for an ordinary user of rules_python
#1169
Comments
You can disable the error python_register_toolchains(
name = ...,
python_version = ...,
ignore_root_user_error = True,
) |
It is good there is an option to choose but you are choosing between two evils: either you get the pyc cache misses or you have to go out of your way to support non-root builds (e.g. when building in a docker container). We have opted for the second evil, but it creates so much extra work. I really wish there was a way to solve the cache issue without this extra requirement. |
we hit the same issues - my feeling is that this is just not the responsibility of |
To be fair, it's probably the CPython to blame, as they programmed to produce the Not sure if they are willing to make a flag to NOT generate |
Works for me! |
When it is not feasible to run as non-root, currently one needs to modify the build files of the project. This is bit clumsy. Could the |
@daixiang0 / @nsubiron Could you please let me know how and where did u make this edit? |
^ I think this workaround doesn't suffice for build tools seeking to use rules_python in their implementations, since they aren't the root module. More context over in hedronvision/bazel-compile-commands-extractor#166 It'd be quite valuable to have this just work out of the box. That is, if running as root, fall back to the best behavior you can rather than erroring. |
Mostly reverts 0e5b1aa Tracking restoration at #168 Please see - #163 - bazelbuild/rules_python#1732 - #165 - (rules_python issue to come) - #166 - bazelbuild/rules_python#1169
Could this setting at least be overridden with an environment variable? I have a |
馃悶 bug report
Affected Rule
The issue is caused by the rule:During the loading phase.
Is this a regression?
I don't think so.
Description
Per #713 ,
rules_python
cannot be used byroot
.CI systems such as CircleCI and BuildBuddy uses
root
user by default.Setting up non-root in those systems aren't very straightforward.
Also, it does not look like a responsibility of an ordinary user of rules_python to have to do this.
馃敩 Minimal Reproduction
Example build event:
https://app.buildbuddy.io/invocation/55238174-54c3-459c-8d80-72722f2d00f9
馃敟 Exception or Error
Relevant error message:
馃實 Your Environment
Operating System:
Output of
bazel version
:Rules_python version:
Anything else relevant?
The text was updated successfully, but these errors were encountered: