cycle support which replaces :pkg with :_pkgbreaks aspects
#1760
Comments
aignas
added a commit
to aignas/rules_python
that referenced
this issue
Mar 23, 2024
This removes the `alias` additions when the package groups are not used fixing alias that attempt to traverse the entire py_library dependency tree. I noticed that for some code that I want to write for `whl_library` having it explicit whether we are using groups or not in the `pip.parse` and or `whl_library` makes the code easier to understand and write. Fixes bazelbuild#1760
github-merge-queue bot
pushed a commit
that referenced
this issue
Mar 27, 2024
This removes the `alias` additions when the package groups are not used fixing alias that attempt to traverse the entire py_library dependency tree. I noticed that for some code that I want to write for `whl_library` having it explicit whether we are using groups or not in the `pip.parse` and or `whl_library` makes the code easier to understand and write. Fixes #1760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
馃悶 bug report
Affected Rule
pip_parse/pip_repository
Is this a regression?
Yes this is a regression.
Description
The change in this PR: https://github.com/bazelbuild/rules_python/pull/1166/files
specifically unconditionally introducing an impl label
_pkghttps://github.com/bazelbuild/rules_python/pull/1166/files#diff-ca70482c01526a5439dab7ac2cb14e637684e50daca723d8e6b4e58ca45cbc67R20that is aliased back to
pkgbreaks aspects. In an aspect, you will get the target of the alias, which will be_pkg. So, with this change, we need to realias back to the public alias.This causes breakages for anyone using aspects.
馃敩 Minimal Reproduction
You can clearly see the generated build files now make the real
:_pkgtarget private.馃實 Your Environment
Operating System:
Output of
bazel version:Rules_python version:
The text was updated successfully, but these errors were encountered: