Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple test that the built and checked in PAR files match. #10

Merged
merged 1 commit into from Feb 16, 2018

Conversation

mattmoor
Copy link
Contributor

No description provided.

@mattmoor
Copy link
Contributor Author

@duggelz Let's see if Bazel CI thinks this is gonna work :)

@mattmoor
Copy link
Contributor Author

@damienmg what is going on here?

@damienmg
Copy link

Tests failed: http://ci.bazel.io/blue/organizations/jenkins/PR%2Frules_python/detail/rules_python/37/tests (fwiw Jenkins team is finally working on making it easier to mark the good step at failing). When you see the job Is yellow, that means that tests have failed and should have a test report somewhere).

@mattmoor
Copy link
Contributor Author

mattmoor commented Sep 20, 2017

Hmm, @duggelz any sense for what might be making this non-deterministic?

@duggelz
Copy link

duggelz commented Sep 20, 2017

Doh. I was going to add a non-determinism test a while back but I couldn't get Bazel-in-bazel to work. Apparently I never filed a bug, and then it slipped off my radar.

The non-determinism stems from the timestamps of the files inside the compressed archive. This is fixed in the internal tool by setting all timestamps to 12:00:01 AM, Jan 1, 1980 (there's a reason for this specific date). I will do the same.

@mattmoor
Copy link
Contributor Author

@duggelz At long last, this should be RFAL :)

thanks for fixing this :D

@mattmoor mattmoor merged commit 3175797 into master Feb 16, 2018
@duggelz duggelz deleted the par-check branch April 7, 2018 06:54
alexeagle pushed a commit to alexeagle/rules_python that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants