fix(release): minimum needed to run twine to publish #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier attempts to publish 0.17 have failed mysteriously at the pypa/gh-action-pypi-publish step. This PR replaces that with a command that I can test locally. TWINE_USERNAME=__token__ TWINE_PASSWORD=pypi-*** bazel run --stamp --embed_label=1.2.4 //python/runfiles:wheel.publish -- --repository testpypi Uploading bazel_runfiles-1.2.4-py3-none-any.whl 100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 11.0/11.0 kB • 00:00 • 27.3 MB/s View at: https://test.pypi.org/project/bazel-runfiles/1.2.4/
alexeagle
force-pushed
the
use_twine
branch
2 times, most recently
from
9c89328
to
90e0db3
Compare
alexeagle
commented
Feb 7, 2023
f0rmiga
requested changes
Feb 7, 2023
Co-authored-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
Co-authored-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
f0rmiga
approved these changes
Feb 7, 2023
rickeylev
approved these changes
Feb 7, 2023
f0rmiga
approved these changes
Feb 7, 2023
ianpegg-bc
pushed a commit
to ianpegg-bc/rules_python
that referenced
this pull request
May 12, 2023
* fix(release): minimum needed to run twine to publish Earlier attempts to publish 0.17 have failed mysteriously at the pypa/gh-action-pypi-publish step. This PR replaces that with a command that I can test locally. TWINE_USERNAME=__token__ TWINE_PASSWORD=pypi-*** bazel run --stamp --embed_label=1.2.4 //python/runfiles:wheel.publish -- --repository testpypi Uploading bazel_runfiles-1.2.4-py3-none-any.whl 100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 11.0/11.0 kB • 00:00 • 27.3 MB/s View at: https://test.pypi.org/project/bazel-runfiles/1.2.4/ * fixup! fix(release): minimum needed to run twine to publish * refactor: move twine deps to its own folder * Update WORKSPACE Co-authored-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com> * Update python/runfiles/BUILD.bazel Co-authored-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com> * show CI failure * remove actual publish for this PR * chore: exclude requirements test on RBE * Add darwin requirements --------- Co-authored-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
This was referenced Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier attempts to publish 0.17 have failed mysteriously at the
pypa/gh-action-pypi-publishstep. This PR replaces that with a command that I can test locally:This is a (hopefully) less contentious subset of #1015 where we just run a binary ourselves but don't try to make a public API out of it yet.