Resolving sibling modules with absolute imports #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0rmiga
requested changes
Jan 28, 2023
|
Ready for review, but the CI is affected by https://github.com/orgs/community/discussions/45830 |
f0rmiga
approved these changes
Jan 31, 2023
| "github.com/bazelbuild/bazel-gazelle/config" | ||
| "github.com/bazelbuild/bazel-gazelle/rule" | ||
| "github.com/emirpasic/gods/sets/treeset" | ||
| godsutils "github.com/emirpasic/gods/utils" | ||
| "path/filepath" |
There was a problem hiding this comment.
Unnecessary and wrong change, we keep standard lib imports at the top.
There was a problem hiding this comment.
That was changed by my GoLand and I didn't notice.
| ":__test__", | ||
| ":generated_test_entrypoint", | ||
| ], | ||
| deps = [":__test__"], |
There was a problem hiding this comment.
This may be a breaking change.
f0rmiga
added a commit
that referenced
this pull request
Feb 1, 2023
This reverts commit 9fc7cfa. Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
f0rmiga
added a commit
that referenced
this pull request
Feb 1, 2023
f0rmiga
pushed a commit
that referenced
this pull request
Feb 2, 2023
* Resolving sibling modules with absolute imports * unconditionally importing conftest * handle from statements * adding tests * adding readme for the new test case Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
f0rmiga
added a commit
that referenced
this pull request
Feb 3, 2023
ianpegg-bc
pushed a commit
to ianpegg-bc/rules_python
that referenced
this pull request
May 12, 2023
* Resolving sibling modules with absolute imports * unconditionally importing conftest * handle from statements * adding tests * adding readme for the new test case
ianpegg-bc
pushed a commit
to ianpegg-bc/rules_python
that referenced
this pull request
May 12, 2023
…1035) Revert "Resolving sibling modules with absolute imports (bazelbuild#1029)" This reverts commit 9fc7cfa. Signed-off-by: Thulio Ferraz Assis <3149049+f0rmiga@users.noreply.github.com>
ianpegg-bc
pushed a commit
to ianpegg-bc/rules_python
that referenced
this pull request
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
py_testandpy_binaryunconditionally depends onpy_libraryin the same package. In order to do that, the Gazelle plugin introduce an virtual import to identify thepy_librarytarget.What is the new behavior?
With the capability of resolving sibling modules introduced in #1027, we can resolve
py_libraryas needed inpy_testandpy_binary, and we no longer need any virtual imports or id forpy_librarytargets. This simplifies the logic.Does this PR introduce a breaking change?
Other information