Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(bzlmod): bump stardoc to 0.6.2 and enable bzlmod docs building #1476

Merged
merged 5 commits into from Oct 9, 2023

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Oct 9, 2023

Before this PR we could not build module_extension docs because of a
really old stardoc version. This updates stardoc to the latest version
and regenerates the documentation. The addition of the docs for
module_extension is out of scope of this PR.

Work towards #1178

Summary:

  • feat(bzlmod): add stardoc as a dev dep
  • feat(docs): enable running on bzlmod
  • chore: USE_BAZEL_VERSION=latest bazel run --enable_bzlmod //docs:update
  • refactor: create wrappers for http_archive and http_file in internal_deps
  • chore(legacy): bump stardoc to 0.6.2

Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aignas aignas added this pull request to the merge queue Oct 9, 2023
Merged via the queue into bazelbuild:main with commit 8dbe88f Oct 9, 2023
2 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Oct 9, 2023
This PR just moves all of the private `bzlmod` code to
`python/private/bzlmod`
and adds minimal `bzl_library` bindings to make the docs the same. Once
#1476
is merged, we can start exposing documentation for `module_extension`.

This includes extras in `pip_install/pip_repository.bzl` just to make it
possible to review and merge #1476 and this in parallel.
github-merge-queue bot pushed a commit that referenced this pull request Nov 2, 2023
The non-bzlmod pip_repository code loads the bzlmod pip_repository code
for some reason,
but nothing else uses that reference. A comment indicates it was only
done to make
merge conflicts easier to manage for PR #1476.
@aignas aignas deleted the feat/bzlmod-doc branch May 13, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants