Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: do not use a wrapper macro for pip_parse #1514

Merged
merged 1 commit into from Oct 20, 2023

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Oct 19, 2023

This brings back the generated documentation for the pip_parse
attributes making switches to default values more prominent.

Towards #1496.

@aignas aignas marked this pull request as ready for review October 19, 2023 14:45
This brings back the generated documentation for the pip_parse
attributes making switches to default values more prominent.

Towards bazelbuild#1496.
@aignas aignas force-pushed the refactor/pip_parse_arg_docs branch from fffdfe6 to 3eabaab Compare October 20, 2023 02:20
@aignas
Copy link
Collaborator Author

aignas commented Oct 20, 2023

Verified that the docs for pip_parse are in https://rules-python--1514.org.readthedocs.build/en/1514/api/pip.html

Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aignas aignas added this pull request to the merge queue Oct 20, 2023
Merged via the queue into bazelbuild:main with commit a6ebc3c Oct 20, 2023
3 checks passed
@aignas aignas deleted the refactor/pip_parse_arg_docs branch May 13, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants