feat(gazelle): allow per-file py_test generation #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right now if there is no |
|
Yes, that's correct. You're right that it worked as expected before in cases where there was no target named |
aignas
requested changes
Nov 16, 2023
adzenith
force-pushed
the
per-file-test-generation
branch
from
02b81ef
to
c993bec
Compare
|
I clarified the changelog and added a second file to both those directories. Thanks for the feedback! |
Previously the per-file target generation only worked for py_library targets. This change makes it so that this works for py_test targets as well. The change is careful to not affect any existing tests, and new tests have been added to check the new functionality.
adzenith
force-pushed
the
per-file-test-generation
branch
from
c993bec
to
9f3e4cf
Compare
aignas
approved these changes
Nov 16, 2023
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the per-file target generation only worked for py_library targets. This change makes it so that this feature works for py_test targets as well.
The change is careful to not affect any existing tests, so I'm not sure if it should count as a breaking change. New tests have been added to check the new functionality.