Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep main module in py_library #1608

Merged
merged 1 commit into from Dec 14, 2023
Merged

Conversation

linzhp
Copy link
Contributor

@linzhp linzhp commented Dec 13, 2023

Unlike Go, the main module of Python can still be imported by other modules. We should keep them in the py_library target to allow such imports.

@linzhp linzhp requested a review from f0rmiga as a code owner December 13, 2023 18:52
@aignas aignas added this pull request to the merge queue Dec 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 13, 2023
@aignas aignas added this pull request to the merge queue Dec 14, 2023
Merged via the queue into bazelbuild:main with commit e7d5c8d Dec 14, 2023
3 checks passed
@linzhp linzhp deleted the keep_py_library branch December 14, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants