Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Bazel support: drop 5, minimum 6.2, current 7.0 #1613

Merged
merged 4 commits into from Dec 15, 2023

Conversation

rickeylev
Copy link
Contributor

@rickeylev rickeylev commented Dec 14, 2023

With the release of Bazel 7, support for 5 is no longer necessary.

Also deletes all the integration tests of the examples. They were broken when
run from the main repo, and CI was only building them, not running them, as part
of the main repo due to having --test_tag_filters=-integration-test. CI runs them
separately in their own workspace.

Work towards #1069

With the release of Bazel 7, support for 5 is no longer necessary.

Work towards bazelbuild#1069
Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickeylev
Copy link
Contributor Author

Huh. Apparently all those bazel_integration_test targets in the examples directory have been broken and CI has been skipping them as part of the main repo tests (CI runs them as separate jobs in separate workspace directories). I just went and deleted them.

@rickeylev rickeylev added this pull request to the merge queue Dec 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 15, 2023
@rickeylev rickeylev added this pull request to the merge queue Dec 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 15, 2023
@rickeylev rickeylev added this pull request to the merge queue Dec 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 15, 2023
@rickeylev rickeylev added this pull request to the merge queue Dec 15, 2023
Merged via the queue into bazelbuild:main with commit ee0a51e Dec 15, 2023
3 checks passed
@rickeylev rickeylev deleted the bazel.5to7.ci branch December 15, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants