Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toolchain, pip.parse): introduce a new '_host' toolchain repo #1644

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Dec 21, 2023

This is for passing it in repository_rules and relies on the canonical
label representation introduced in bazel 6.0 and symlink support (needs
to be present on Windows) to work.

This allows the users to not need to load the interpreter label from
a .bzl file but instead specify the label in the form of
@<mytoolchainrepo>_host//:python.

In order to make it work robustly on Windows, we do
repository_ctx.path(python_interpreter_label).realpath to get the actual
path of the Python interpreter on both, bzlmod and non-bzlmod setups on
Windows within the whl_library repository rule.

Work towards #1643.

@aignas aignas marked this pull request as ready for review December 21, 2023 01:35
@rickeylev
Copy link
Contributor

Oh this is gonna be tough to remember. @chrislovecnm do you remember what the issue was with windows and trying to symlink to the python interpreter from another repo?

@rickeylev
Copy link
Contributor

Ah, this might be it: #1265

Something about: the symlink can't be executed directly / powershell issue / dll's can't be found from the symlink's location ?

@aignas aignas force-pushed the feat/setup-a-host-interpreter-for-external-repo-usage branch from 5f65e16 to 4840d42 Compare December 21, 2023 08:22
@aignas
Copy link
Collaborator Author

aignas commented Dec 21, 2023

I am wondering then why the CI is still passing. Maybe the
repository_ctx usage is good enough with symlinks, because
the symlink gets always resolve the real path before executing?

Just to be explicit, I am not using the symlink in toolchain
resolution. For that we already have the alias repos and this
is only for the repository_ctx usecase and the Windows CI seems
to be still happy. Do we need to make this host_python repo
internal to rules_python in some way?

@aignas
Copy link
Collaborator Author

aignas commented Dec 21, 2023

Yeah, the previous path.realpath usage was only on Windows bzlmod, when I enabled it for everything, it started working again (the multi-python-version tests on non-bzlmod started failing because the path.realpath workaround was missing there.

@aignas aignas force-pushed the feat/setup-a-host-interpreter-for-external-repo-usage branch from 1a97810 to 7cf8787 Compare December 21, 2023 23:28
examples/multi_python_versions/WORKSPACE Show resolved Hide resolved
examples/pip_parse_vendored/BUILD.bazel Show resolved Hide resolved
examples/pip_parse_vendored/BUILD.bazel Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@aignas aignas force-pushed the feat/setup-a-host-interpreter-for-external-repo-usage branch from 7cf8787 to 53a553e Compare December 22, 2023 13:06
This is for passing it in repository_rules and relies on the canonical
label representation introduced in bazel 6.0 and symlink support (needs
to be present on Windows) to work.

This allows the users to not need to `load` the interpreter label from
a `.bzl` file but instead specify the label in the form of
`@<mytoolchainrepo>_host//:python`.

Work towards bazelbuild#1643.
@aignas aignas force-pushed the feat/setup-a-host-interpreter-for-external-repo-usage branch from 53a553e to 991d4c0 Compare January 9, 2024 00:32
@rickeylev rickeylev added this pull request to the merge queue Jan 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 9, 2024
@aignas aignas added this pull request to the merge queue Jan 9, 2024
Merged via the queue into bazelbuild:main with commit 4fe0db3 Jan 9, 2024
4 checks passed
@aignas aignas deleted the feat/setup-a-host-interpreter-for-external-repo-usage branch May 13, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants