Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix launching Python 3.11 from <3.8 on macOS #1709

Merged
merged 2 commits into from
Jan 23, 2024
Merged

fix: fix launching Python 3.11 from <3.8 on macOS #1709

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
816163e
fix: fix launching Python 3.11 from <3.8 on macOS
armandomontanez Jan 20, 2024
96b9216
Merge branch 'bazelbuild:main' into fix_bootstrap_on_older_macos
armandomontanez Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions python/private/python_bootstrap_template.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,6 +528,13 @@ def Main():
else:
cov_tool = None

# Some older Python versions on macOS (namely Python 3.7) may unintentionally
# leave this environment variable set after starting the interpreter, which
# causes problems with Python subprocesses correctly locating sys.executable,
# which subsequently causes failure to launch on Python 3.11 and later.
if '__PYVENV_LAUNCHER__' in os.environ:
del os.environ['__PYVENV_LAUNCHER__']

new_env.update((key, val) for key, val in os.environ.items() if key not in new_env)

workspace = None
Expand Down