pip_import: Let users override system Python via PYTHON env var #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CentOS 6 provides Python 2.6.6, which is too old to satisfy `pip_import`'s dict comprehension requirement. I need some way to point `pip_import` to an alternate Python distribution. This change adds system Python override to `pip_import` and `whl_library` via the `PYTHON` environment variable. Resolves #178.
|
Hi Ryan, thanks for the PR. The recently merged #252 allows you to include a Compared with those approaches, this one allows the user to easily inject an alternate Python interpreter by setting an env var. But I don't think it's necessary to directly support that use case if we have an attribute users can set in their WORKSPACE. Note that the env var behavior can now be obtained by writing a macro wrapper around In light of this, I'll let #256 mark this PR closed. |
Merged
Sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CentOS 6 provides Python 2.6.6, which is too old to satisfy
pip_import'sdict comprehension requirement. I need some way to point
pip_importtoan alternate Python distribution.
This change adds system Python override to
pip_importandwhl_libraryvia the
PYTHONenvironment variable.Resolves #178.