Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buildifier defects #449

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Fix buildifier defects #449

merged 1 commit into from
Apr 7, 2021

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Apr 7, 2021 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

This fixes buildifier defects which started appearing after a fix to Bazel CI was merged bazelbuild/continuous-integration#1080

Issue Number: N/A

What is the new behavior?

CI should now be passing.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Apr 7, 2021
@UebelAndre UebelAndre changed the title Ran buildifier Fix buildifier defects Apr 7, 2021
@UebelAndre UebelAndre marked this pull request as ready for review April 7, 2021 00:53
alexeagle
alexeagle approved these changes Apr 7, 2021
View reviewed changes
Copy link
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm not sure what changed on CI such that new PRs are getting flagged.

@alexeagle alexeagle merged commit bc256ef into bazelbuild:master Apr 7, 2021
@UebelAndre UebelAndre deleted the buildifier branch April 7, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@andyscott andyscott Awaiting requested review from andyscott

@brandjon brandjon Awaiting requested review from brandjon

@lberki lberki Awaiting requested review from lberki

@thundergolfer thundergolfer Awaiting requested review from thundergolfer

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@UebelAndre @alexeagle