Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "pip_compile: remove external/workspace_name prefix from gener… #794

Merged
merged 6 commits into from
Aug 27, 2022

Conversation

alexeagle
Copy link
Collaborator

…ated requirements.txt (#690)"

This reverts commit aef17ad.

Fixes #766

@hrfuller
Copy link
Contributor

hrfuller commented Aug 18, 2022

I know we decided this kind of drive-by change doesn't follow our principles for evolving the project, and makes the code that much harder to read, but just curious were there any known breakages caused by this? Just saw the linked ticket.

Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@groodt groodt merged commit edfd9f4 into main Aug 27, 2022
@groodt groodt deleted the revert_690 branch August 27, 2022 22:07
Copy link

@Ghjkvvgj Ghjkvvgj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y

Copy link

@Ghjkvvgj Ghjkvvgj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gil

ianpegg-bc pushed a commit to ianpegg-bc/rules_python that referenced this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local relative requirements compile fails under 0.10.0+
4 participants