chore: publish a runfiles library as a wheel #995
Conversation
|
Looks like our buildifier presubmit check is broken, it complains about |
Wire it up to GH actions so it is published for each release. Tested locally with: bazel build python/runfiles:wheel --embed_label=1.0.2 --stamp PYTHONPATH=bazel-bin/python/runfiles/bazel_runfiles-_BUILD_EMBED_LABEL_-py3-none-any.whl python >>> import runfiles >>> runfiles.Create() Note, I would have liked to call the package bazel-runfiles, but this isn't possible without either refactoring the paths in this repo, or doing some fancy starlark to copy files around to create a folder that we turn into the wheel. There is no project https://pypi.org/project/runfiles though there is a https://pypi.org/project/runfile We could try harder to get the name we prefer.
|
It's broken because the new buildifier release formats |
|
Yeah, I rebased over a commit I added on |
|
The logic in |
|
Yeah I'll try adding the integration test before merging this. |
Co-authored-by: Richard Levasseur <richardlev@gmail.com>
|
@rickeylev looks like your personal email isn't properly connected with your GitHub identity in a way that Google's CLA bot understands - this is the result of applying your suggestions. You might need to add that email address in http://go/github ? |
|
CLA issue fixed |
|
Cool, thanks! |
our 0.17 release is stuck on this step. Partially reverts #995
our 0.17 release is stuck on this step. Partially reverts #995
* chore: publish a runfiles library as a wheel Wire it up to GH actions so it is published for each release. Tested locally with: bazel build python/runfiles:wheel --embed_label=1.0.2 --stamp PYTHONPATH=bazel-bin/python/runfiles/bazel_runfiles-_BUILD_EMBED_LABEL_-py3-none-any.whl python >>> import runfiles >>> runfiles.Create() Note, I would have liked to call the package bazel-runfiles, but this isn't possible without either refactoring the paths in this repo, or doing some fancy starlark to copy files around to create a folder that we turn into the wheel. There is no project https://pypi.org/project/runfiles though there is a https://pypi.org/project/runfile We could try harder to get the name we prefer. * Apply suggestions from code review Co-authored-by: Richard Levasseur <richardlev@gmail.com> * more code review cleanup Co-authored-by: Richard Levasseur <richardlev@gmail.com>
our 0.17 release is stuck on this step. Partially reverts bazelbuild#995
Wire it up to GH actions so it is published for each release.
Tested locally with:
Note, I would have liked to call the package bazel-runfiles, but this isn't possible without either refactoring the paths in this repo, or doing some fancy starlark to copy files around to create a folder that we turn into the wheel. There is no project https://pypi.org/project/runfiles though there is a https://pypi.org/project/runfile
We could try harder to get the name we prefer.