Skip to content

Commit

Permalink
Updated min tested version to 3.5.0 and improved some vernacular (#586)
Browse files Browse the repository at this point in the history
* Updated some vernacular

* Updated min version to 4.0.0

* Addressed PR feedback

* Lowered min tested version to 3.5.0
  • Loading branch information
UebelAndre committed Feb 17, 2021
1 parent 14eb6f3 commit 129605e
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ tasks:
- "//test/versioned_dylib:versioned_dylib_test"
ubuntu2004:
name: "Minimum Supported Version"
bazel: "3.0.0"
bazel: "3.5.0"
build_targets: *default_linux_targets
test_targets: *default_linux_targets
macos:
Expand Down
5 changes: 4 additions & 1 deletion docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,10 @@ load("@rules_rust//rust:repositories.bzl", "rust_repositories")
rust_repositories()
```

The rules are under active development, as such the lastest commit on the master branch should be used. `master` currently requires Bazel >= 3.0.0.
The rules are under active development, as such the lastest commit on the
`main` branch should be used. `main` is only tested against `4.0.0` as the
minimum supported version of Bazel. Though previous versions may still be
supported in certain environments.

## Rules

Expand Down
2 changes: 1 addition & 1 deletion rust/platform/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ package(default_visibility = ["//visibility:public"])
declare_config_settings()

package_group(
name = "function_transition_whitelist",
name = "function_transition_allowlist",
packages = [
"//...",
],
Expand Down
4 changes: 4 additions & 0 deletions tools/allowlists/function_transition_allowlist/BUILD
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package_group(
name = "function_transition_allowlist",
packages = ["//..."],
)
4 changes: 0 additions & 4 deletions tools/whitelists/function_transition_whitelist/BUILD

This file was deleted.

4 changes: 2 additions & 2 deletions wasm_bindgen/wasm_bindgen.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ rust_wasm_bindgen = rule(
allow_single_file = True,
cfg = wasm_bindgen_transition,
),
"_whitelist_function_transition": attr.label(
default = Label("//tools/whitelists/function_transition_whitelist"),
"_allowlist_function_transition": attr.label(
default = Label("//tools/allowlists/function_transition_allowlist"),
),
},
outputs = {
Expand Down

0 comments on commit 129605e

Please sign in to comment.