Skip to content

Commit

Permalink
Fix iOS linker arguments (#1186)
Browse files Browse the repository at this point in the history
These were interpreted as a single argument, instead of 2 arguments
separated by a space, this lead to this linker error:

```
clang: error: unknown argument: '-framework Security'
clang: error: unknown argument: '-framework Foundation'
```

Instead we can use the `-Wl` syntax so we don't have to worry about
ordering.
  • Loading branch information
keith committed Mar 14, 2022
1 parent de726a1 commit eb7db68
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rust/platform/triple_mappings.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ _SYSTEM_TO_STDLIB_LINKFLAGS = {
"freebsd": ["-lexecinfo", "-lpthread"],
"fuchsia": ["-lzircon", "-lfdio"],
"illumos": ["-lsocket", "-lposix4", "-lpthread", "-lresolv", "-lnsl", "-lumem"],
"ios": ["-lSystem", "-lobjc", "-framework Security", "-framework Foundation", "-lresolv"],
"ios": ["-lSystem", "-lobjc", "-Wl,-framework,Security", "-Wl,-framework,Foundation", "-lresolv"],
# TODO: This ignores musl. Longer term what does Bazel think about musl?
"linux": ["-ldl", "-lpthread"],
"nacl": [],
Expand Down

0 comments on commit eb7db68

Please sign in to comment.