Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate rust rules towards new C++ toolchain API #131

Closed
hlopko opened this issue Oct 18, 2018 · 0 comments
Closed

Migrate rust rules towards new C++ toolchain API #131

hlopko opened this issue Oct 18, 2018 · 0 comments
Assignees
@hlopko
Labels
enhancement

Comments

@hlopko
Copy link
Member

hlopko commented Oct 18, 2018

Rules rust use currently deprecated C++ toolchain api on ctx.fragments.cpp. This API will be removed in Bazel 0.20 (incompatible change removing API from ctx.fragments.cpp tracking issue, incompatible change removing API from CcToolchainInfo tracking issue). See linked issues for migration notes.

I will temporarily disable rules_rust from https://buildkite.com/bazel/bazel-with-downstream-projects-bazel, and will reenable once this issue is fixed.
@hlopko hlopko self-assigned this Oct 18, 2018
hlopko added a commit to bazelbuild/continuous-integration that referenced this issue Oct 18, 2018
@hlopko
Temporarily disable rules_rust until #131 is fixed
0e23d2e 
I will re-enable once bazelbuild/rules_rust#131 is fixed.
@mfarrugi mfarrugi mentioned this issue Oct 19, 2018
Merged
hlopko added a commit to bazelbuild/continuous-integration that referenced this issue Oct 19, 2018
@hlopko
Disabling rules_docker
9fe18cf 
Reenable once bazelbuild/rules_rust#131 is fixed and rules_docker use the fixed version of rules_rust.
hlopko added a commit that referenced this issue Oct 19, 2018
@hlopko
Migrate rules_rust to the new Starlark C++ toolchain API
aa91acc 
This is needed for rules_rust to be forward compatible with Bazel 0.20.
Tracking issues for migration:

* bazelbuild/bazel#6380
* bazelbuild/bazel#6434

Fixes #131.
@hlopko hlopko mentioned this issue Oct 19, 2018
Merged
hlopko added a commit that referenced this issue Oct 22, 2018
@hlopko
Migrate rules_rust to the new Starlark C++ toolchain API (#133)
271d790 
This is needed for rules_rust to be forward compatible with Bazel 0.20.
Tracking issues for migration:

* bazelbuild/bazel#6380
* bazelbuild/bazel#6434

Fixes #131.
xingao267 pushed a commit to xingao267/rules_rust that referenced this issue Oct 26, 2018
@hlopko
Migrate rules_rust to the new Starlark C++ toolchain API (bazelbuild#133
e7e5d6f 
)

This is needed for rules_rust to be forward compatible with Bazel 0.20.
Tracking issues for migration:

* bazelbuild/bazel#6380
* bazelbuild/bazel#6434

Fixes bazelbuild#131.
xingao267 pushed a commit to xingao267/rules_rust that referenced this issue Oct 26, 2018
@hlopko
Migrate rules_rust to the new Starlark C++ toolchain API (bazelbuild#133
32ed22c 
)

This is needed for rules_rust to be forward compatible with Bazel 0.20.
Tracking issues for migration:

* bazelbuild/bazel#6380
* bazelbuild/bazel#6434

Fixes bazelbuild#131.
joeleba pushed a commit to joeleba/continuous-integration that referenced this issue Jun 17, 2019
@hlopko @joeleba
Temporarily disable rules_rust until bazelbuild#131 is fixed
a27c222 
I will re-enable once bazelbuild/rules_rust#131 is fixed.
joeleba pushed a commit to joeleba/continuous-integration that referenced this issue Jun 17, 2019
@hlopko @joeleba
Disabling rules_docker
e749e67 
Reenable once bazelbuild/rules_rust#131 is fixed and rules_docker use the fixed version of rules_rust.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hlopko hlopko

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hlopko