Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup instructions are incomplete (or broken) #167

Closed
nlopezgi opened this issue Dec 3, 2018 · 1 comment
Closed

Setup instructions are incomplete (or broken) #167

nlopezgi opened this issue Dec 3, 2018 · 1 comment

Comments

@nlopezgi
Copy link
Contributor

nlopezgi commented Dec 3, 2018

I had to add

load("@io_bazel_rules_rust//:workspace.bzl", "bazel_version")

bazel_version(name = "bazel_version")

below the call to rust_repositories()

It seems either the README needs to be updated or (better) the call to rust_repositories() should do the loading of the bazel_version(name = "bazel_version") repo
@mfarrugi
Copy link
Collaborator

mfarrugi commented Dec 4, 2018

I agree we should have one public dependencies function, I will pick this up eventually if no one else does.

@mfarrugi mfarrugi mentioned this issue Dec 5, 2018
Closed
mfarrugi added a commit that referenced this issue Jan 10, 2019
@mfarrugi
Fix setup snippet in the README (#167)
f991ac6
mfarrugi added a commit that referenced this issue Jan 10, 2019
@mfarrugi
Fix setup snippet in the README (#167) (#184)
5894d35
@mfarrugi mfarrugi closed this as completed Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mfarrugi @nlopezgi