Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compile_data to rust rules #222

Closed
mfarrugi opened this issue May 6, 2019 · 0 comments · Fixed by #516
Closed

Add compile_data to rust rules #222

mfarrugi opened this issue May 6, 2019 · 0 comments · Fixed by #516

Comments

@mfarrugi
Copy link
Collaborator

mfarrugi commented May 6, 2019

This is a tangent from #208

Currently we overload the data attr to be both runtime and compile time data, when it should only be runtime.

https://docs.bazel.build/versions/master/be/java.html#java_library.data is precedent for 'should mean runtime only'.. not sure what else is out there. I think I have seen other rules be more permissive of what is allowed in srcs as well.
@kornholi kornholi mentioned this issue Nov 7, 2019
Closed
@mfarrugi mfarrugi mentioned this issue Oct 21, 2020
Closed
dae added a commit to ankitects/rules_rust that referenced this issue Dec 1, 2020
@dae
add compile_data argument for data required at compile time
b0f7bd9 
Closes bazelbuild#222
@dae dae mentioned this issue Dec 1, 2020
Merged
dae added a commit to ankitects/rules_rust that referenced this issue Dec 10, 2020
@dae
add compile_data argument for data required at compile time
ecec7b8 
Closes bazelbuild#222
illicitonion pushed a commit that referenced this issue Dec 12, 2020
@dae
add compile_data argument for data required at compile time (#516)
eef7f56 
Using the existing data argument for build-time data dependencies causes the files to also show up in the runfiles. This can be seen when using rules_docker's rust_image() for example - the files are included in the image twice; once in the binary and once in their original form.

If this is accepted I'll send through a PR to cargo-raze to expose this for third-party crates similar to data_attr.

Closes #222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add compile_data argument for data required at compile time ankitects/rules_rust
1 participant
@mfarrugi