Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rand 0.7.0 doesn't build #238

Closed
sayrer opened this issue Jul 6, 2019 · 2 comments
Closed

rand 0.7.0 doesn't build #238

sayrer opened this issue Jul 6, 2019 · 2 comments

Comments

@sayrer
Copy link
Contributor

sayrer commented Jul 6, 2019

It doesn't look like rules_rust supports the dependency syntax in this crate.

https://github.com/rust-random/rand/blob/84d9be45f082dba41bf3ad22c20eb5e573a3ccaa/Cargo.toml#L59

@kornholi
Copy link
Contributor

Builds fine for me with cargo-raze 0.2.9:

$ bazel build @third_party__rand__0_7_2//:rand
INFO: Invocation ID: 9a5415b1-a5f1-41e7-b426-164f29d30b77
INFO: Analyzed target @third_party__rand__0_7_2//:rand (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
Target @third_party__rand__0_7_2//:rand up-to-date:
  bazel-bin/external/third_party__rand__0_7_2/librand--2018866632.rlib

@hlopko
Copy link
Member

hlopko commented Nov 3, 2019

Yup I was able to build rand as well, I'll close this issue now assuming its fixed. Please complain if you can still reproduce the failure (and please provide repro instructions and error output).

Thanks!

@hlopko hlopko closed this as completed Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants