Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust_library should produce non-rlib crates with correct file extensions #36

Closed
davidzchen opened this issue Feb 21, 2017 · 3 comments
Closed

Comments

@davidzchen
Copy link
Member

Currently, the rust_library rule only outputs rlibs regardless of the value of crate_type. In order to correctly support all the different crate types, `rust_library should produce the crates with the correct file extensions.

Proposal

  • Make the rust_library rule internal by renaming it to _rust_library
  • Add a new outs attribute to the _rust_library rule to support custom outputs
  • Add a rust_library macro that wraps the _rust_library rule. Based on the value of crate_type, it adds a _rust_library rule with outs set with the name of the output library with the correct file extensions according to the Rust documentation
@davidzchen
Copy link
Member Author

@damienmg
Copy link
Collaborator

SGTM

@acmcarther
Copy link
Collaborator

This was fixed in:
#38

... which produces outputs with the right file extension for the toolchain and crate_type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants