Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce proto_compile_deps and grpc_compile_deps to rust_proto_toolchain #483

Closed
UebelAndre opened this issue Nov 8, 2020 · 2 comments · Fixed by #678
Closed

Reintroduce proto_compile_deps and grpc_compile_deps to rust_proto_toolchain #483

UebelAndre opened this issue Nov 8, 2020 · 2 comments · Fixed by #678

Comments

@UebelAndre
Copy link
Collaborator

@damienmg There is a TODO in proto/toolcahin.bzl

# TODO(damienmg): Once bazelbuild/bazel#6889 is fixed, reintroduce
# proto_compile_deps and grpc_compile_deps and remove them from the
# rust_proto_library and grpc_proto_library.
rust_proto_toolchain = rule(

The issue (bazelbuild/bazel#6889) looks closed now so is this something that should be done still?
@damienmg
Copy link
Collaborator

damienmg commented Nov 9, 2020

Probably yes.

@UebelAndre UebelAndre mentioned this issue Dec 2, 2020
Closed
@UebelAndre
Copy link
Collaborator Author

This also seems related to bazelbuild/bazel#11584

@UebelAndre UebelAndre mentioned this issue Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@damienmg @UebelAndre